There are many things you have to keep in mind when taking photos of both total and partial eclipses. It is important to remember that it is never safe to take photos of the sun without proper solar protection before the Diamond Ring effect (~5 seconds before totality). During totality it is safe to take photos without solar protection. Here is a resource that has even more suggestions on how to take photographs of solar eclipses.